Re: Proposal: Make cfbot fail on patches not created by "git format-patch"
От | Ashutosh Bapat |
---|---|
Тема | Re: Proposal: Make cfbot fail on patches not created by "git format-patch" |
Дата | |
Msg-id | CAExHW5v2P6_LT6qyxrOKzT2D9hr01tGdqgVYPPHVzXkcJ_3GiA@mail.gmail.com обсуждение исходный текст |
Ответ на | Proposal: Make cfbot fail on patches not created by "git format-patch" (Jelte Fennema-Nio <me@jeltef.nl>) |
Ответы |
Re: Proposal: Make cfbot fail on patches not created by "git format-patch"
|
Список | pgsql-hackers |
On Fri, May 16, 2025 at 1:45 PM Jelte Fennema-Nio <me@jeltef.nl> wrote:
On Fri, 16 May 2025 at 12:24, Jacob Champion
<jacob.champion@enterprisedb.com> wrote:
>
> On Fri, May 16, 2025 at 12:12 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > That outcome seems entirely horrible to me. If you want to flag the lack
> > of a commit message somehow, fine, but don't prevent CI from running.
>
> Personally I also prefer nudges to gates.
Okay, reasonable feedback. How about we add a CI job that does a
"quality check". That's much less strong, as all the other tests will
still run, but people would get a failing CI job which tells them that
something is wrong. We could also include a pgindent in that CI job.
+1. Knowing whether to use git am or patch to apply the patch itself will save reviewers' time.
Best Wishes,
Ashutosh Bapat
В списке pgsql-hackers по дате отправления: