Re: Remove PG_MMAP_FLAGS

On Fri, Jan 23, 2026 at 10:12 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Jan 23, 2026 at 08:04:18AM +0530, Ashutosh Bapat wrote:
> > As Peter mentioned in the shared buffers resizing thread [1] it's
> > placement and name in mem.h led us to think that it affects all mmap
> > calls or that all mmap calls should use those flags. Neither of which
> > is true. We have different mmap calls using different set of flags.
> > Attached patch proposes changes similar (not exact) as you suggest
> > above. Please take a look.
> >
> > [1] https://www.postgresql.org/message-id/12add41a-7625-4639-a394-a5563e349322@eisentraut.org
>
> Okay, point taken.  I can live with your patch suggestion based on
> what you have attached.

Thanks.

I revised the patch a bit. The macro had parenthesis around the macro
definition which are not required in the assignment. Removed them.
Also revised the commit message a bit.

--
Best Wishes,
Ashutosh Bapat