On Fri, Jan 5, 2024 at 12:49 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> I mean why? We test a bunch of stuff in src/test/modules/, and this
> is not intended to be released to the outside world.
>
> Putting that in contrib/ has a lot of extra cost. One is
> documentation and more complexity regarding versioning when it comes
> to upgrading it to a new version. I don't think that it is a good
> idea to deal with this extra load of work for something that I'd aim
> to be used for having improved *test* coverage, and the build switch
> should stay. Saying that, I'd be OK with renaming the module to
> injection_points,
Ok. Thanks.
> but I will fight hard about keeping that in
> src/test/modules/. That's less maintenance headache to think about
> when having to deal with complex racy bugs.
For me getting this feature in code in a usable manner is more
important than its place in the code. I have no plans to fight over
it. :).
--
Best Wishes,
Ashutosh Bapat