Re: DOCS: add helpful partitioning links

Поиск
Список
Период
Сортировка
От Ashutosh Bapat
Тема Re: DOCS: add helpful partitioning links
Дата
Msg-id CAExHW5tgH3MPR-xE5_oAhyw1ZE9CGuttHHjjQCHiC474k1K-AQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: DOCS: add helpful partitioning links  (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>)
Ответы Re: DOCS: add helpful partitioning links  (Robert Treat <rob@xzilla.net>)
Список pgsql-hackers


On Wed, Mar 20, 2024 at 5:22 PM Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> wrote:


On Tue, Mar 19, 2024 at 6:38 PM Robert Treat <rob@xzilla.net> wrote:

I've put it in the next commitfest with target version of 17, and I've
added you as a reviewer :-)


Thanks.
 
Also, attached is an updated patch with your change above which should
apply cleanly to the current git master.

It did apply for me now.

The HTML renders good, the links work as expected.

I think the original word "option" instead of "command" is better since we are talking about LIKE as an option to CREATE TABLE instead of CREATE TABLE command.

+     but any future attached or created partitions will be indexed as well.

I think just "any future partitions will be indexed as well" would suffice, no need to mention whether they were created or attached.

+     One limitation when creating new indexes on partitioned tables is that it
+     is not possible to use the <literal>CONCURRENTLY</literal>
+     qualifier when creating such a partitioned index.  To avoid long

The sentence uses two different phrases, "indexes on partitioned tables" and "partitioned index", for the same thing in the same sentence. Probably it is better to leave original sentence as is.

But I think it's time for a committer to take a look at this. Please feel free to address the above comments if you agree with them. Marking this as ready for committer.


The patch changes things not directly related to $Subject. It will be good to add a commit message to the patch describing what are those changes about. I observe that all of them are in section "partition maintenance". https://www.postgresql.org/docs/16/ddl-partitioning.html#DDL-PARTITIONING-DECLARATIVE-MAINTENANCE. Do you see any more edits required in that section?


--
Best Wishes,
Ashutosh Bapat

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: Catalog domain not-null constraints
Следующее
От: vignesh C
Дата:
Сообщение: Re: speed up a logical replica setup