Hi,
While testing patch (0001-pgbench-Allow-variables-to-be-used-as-an-SQL-literal.patch), I reproduced the CI failure reported by Michael (-Werror=switch for PQUOTE_SHELL_ARG in replaceVariable()).
Attached is a small follow-up patch that handles
-The missing enum case,
-Removes an unused variable
-Ensures quoted_value is always initialized.
This builds cleanly for me.
Regards,
Lakshmi
On Thu, Sep 18, 2025 at 03:33:30PM +0900, Yugo Nagata wrote:
> Any thought?
Note that the CI is complaining a bit. Relevant extract:
[22:51:36.908] pgbench.c: In function ‘replaceVariable’:
[22:51:36.908] pgbench.c:1990:9: error: enumeration value
‘PQUOTE_SHELL_ARG’ not handled in switch [-Werror=switch]
[22:51:36.908] 1990 | switch (quote)
--
Michael