Re: define pg_structiszero(addr, s, r)
| От | Ranier Vilela |
|---|---|
| Тема | Re: define pg_structiszero(addr, s, r) |
| Дата | |
| Msg-id | CAEudQArxZZk2YiZ8nvGym26yTtNoCiS6bTtmdWq1QvKayevOZQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: define pg_structiszero(addr, s, r) (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>) |
| Ответы |
Re: define pg_structiszero(addr, s, r)
|
| Список | pgsql-hackers |
Em qui., 14 de nov. de 2024 às 07:09, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> escreveu:
Hi,
On Thu, Nov 14, 2024 at 09:27:06AM +0900, Michael Paquier wrote:
> Makes sense to me to just do that, with a first < 8 loop, and a second
> for the 8~63 range.
Thanks for looking at it!
> There is also a "cant'" in the last size_t check. Simple typo.
Please find attached v12, with more comments and comments changes to explain
the multiple cases (for safety) and phases (for efficiency).
Is it worth mentioning that pg_memory_is_all_zeros does not work correctly on 32-bit systems?
(63 < (size_t) * 8) /* 63 - 32*/
Or do we adjust magic constants according to 32/64 bit?
best regards,
Ranier Vilela
В списке pgsql-hackers по дате отправления: