Re: Should we remove -Wdeclaration-after-statement?

Поиск
Список
Период
Сортировка
От Ranier Vilela
Тема Re: Should we remove -Wdeclaration-after-statement?
Дата
Msg-id CAEudQAqfsbr1CUdNW788LSYveS==PvhJwjg6AMPfMGSsAuSo7Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Should we remove -Wdeclaration-after-statement?  (Jelte Fennema-Nio <postgres@jeltef.nl>)
Список pgsql-hackers
Em seg., 29 de jan. de 2024 às 12:03, Jelte Fennema-Nio <postgres@jeltef.nl> escreveu:
I feel like this is the type of change where there's not much
discussion to be had. And the only way to resolve it is to use some
voting to gauge community opinion.

So my suggestion is for people to respond with -1, -0.5, +-0, +0.5, or
+1 to indicate support against/for the change.

I'll start: +1

Attached is a patch that removes -Wdeclaration-after-statement in the
codebase.
-1
C89 IMO is the best for C readability.
None surprise, once you read the block declaration,
You know all about the vars in the function.

Best regards,
Ranier Vilela

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ranier Vilela
Дата:
Сообщение: Optmize bitmapword macros calc (src/backend/nodes/bitmapset.c)
Следующее
От: Steve Chavez
Дата:
Сообщение: Re: psql: add \create_function command