Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c)

Поиск
Список
Период
Сортировка
От Ranier Vilela
Тема Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c)
Дата
Msg-id CAEudQAqfY3B64jTtO5M2wJhYEDJQ3Xx+NQV7Z=wcqwLeP64=AQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Simplified version of read_binary_file (src/backend/utils/adt/genfile.c)  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Дерево обсуждения
Em sex., 11 de set. de 2020 às 17:44, Tom Lane <tgl@sss.pgh.pa.us> escreveu:
Ranier Vilela <ranier.vf@gmail.com> writes:
> New version, with support to read Virtual File (pipe, FIFO and socket).
> With assert, in case, erroneous, of trying to read a pipe, with offset.

I do agree that it might be worth skipping the fseeko call in the
probably-common case where seek_offset is zero.  Otherwise I don't
see much reason to change what's there.
Tom, if you think it's worth it, I agree with only avoiding syscal fseeko.

regards,
Ranier Vilela
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Geoghegan
Дата:
Сообщение: Re: logtape.c stats don't account for unused "prefetched" block numbers
Следующее
От: Peter Geoghegan
Дата:
Сообщение: Re: logtape.c stats don't account for unused "prefetched" block numbers