Re: Avoid possible memory leak (src/common/rmtree.c)
| От | Ranier Vilela |
|---|---|
| Тема | Re: Avoid possible memory leak (src/common/rmtree.c) |
| Дата | |
| Msg-id | CAEudQAqGn33+p=ZtaGUBTEUYc1727xaN6vbRkBPu+61dXPiM9w@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Avoid possible memory leak (src/common/rmtree.c) (Michael Paquier <michael@paquier.xyz>) |
| Ответы |
Re: Avoid possible memory leak (src/common/rmtree.c)
|
| Список | pgsql-hackers |
Em sex, 28 de jul de 2023 11:54 PM, Michael Paquier <michael@paquier.xyz> escreveu:
On Tue, Jul 25, 2023 at 04:45:22PM +0200, Daniel Gustafsson wrote:
> Skimming the tree there doesn't seem to be any callers which aren't exiting or
> ereporting on failure so the real-world impact seems low. That being said,
> silencing static analyzers could be reason enough to delay allocation.
A different reason would be out-of-core code that uses rmtree() in a
memory context where the leak would be an issue if facing a failure
continuously? Delaying the allocation after the OPENDIR() seems like
a good practice anyway.
Thanks for the commit, Michael.
best regards,
Ranier Vilela
В списке pgsql-hackers по дате отправления: