On Fri, 2 Jul 2021 at 19:48, Ranier Vilela <ranier.vf@gmail.com> wrote: > > If you allow me a small suggestion. > Move the initializations of the variable tmp_var to after check if the function can run. > Saves some cycles, when not running. >
OK, thanks. I agree, on grounds of neatness and consistency with nearby code, so I've done it that way.
Thanks.
Note, however, that it won't make any difference to performance in the way that you're suggesting -- elog() in Postgres is used for "should never happen, unless there's a software bug" errors, rather than, say, "might happen for certain invalid inputs" errors, so init_var() should always be called in these functions.
I agree that in this case, most of the time, elog is not called.
But by writing this way, you are following the principle of not doing unnecessary work until it is absolutely necessary. If you follow this principle, in general, the performance will always be better.