Re: [PATCH] Windows port, fix some resources leaks

Поиск
Список
Период
Сортировка
Искать
От
Ranier Vilela
Тема
Re: [PATCH] Windows port, fix some resources leaks
Дата
Msg-id
CAEudQApiqODoUONWU0yrfLPKeekVgO03ja77FDTt1W+LUXQrKg@mail.gmail.com
Ответ на
Re: [PATCH] Windows port, fix some resources leaks (Alvaro Herrera)
Список
Дерево обсуждения
[PATCH] Windows port, fix some resources leaks Ranier Vilela <ranier.vf@gmail.com>
Re: [PATCH] Windows port, fix some resources leaks Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Re: [PATCH] Windows port, fix some resources leaks Ranier Vilela <ranier.vf@gmail.com>
Re: [PATCH] Windows port, fix some resources leaks Michael Paquier <michael@paquier.xyz>
Re: [PATCH] Windows port, fix some resources leaks Ranier Vilela <ranier.vf@gmail.com>
Re: [PATCH] Windows port, fix some resources leaks Michael Paquier <michael@paquier.xyz>
Re: [PATCH] Windows port, fix some resources leaks Robert Haas <robertmhaas@gmail.com>
Re: [PATCH] Windows port, fix some resources leaks Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [PATCH] Windows port, fix some resources leaks Robert Haas <robertmhaas@gmail.com>
Re: [PATCH] Windows port, fix some resources leaks Michael Paquier <michael@paquier.xyz>
Re: [PATCH] Windows port, fix some resources leaks Ranier Vilela <ranier.vf@gmail.com>
Re: [PATCH] Windows port, fix some resources leaks Ranier Vilela <ranier.vf@gmail.com>
Re: [PATCH] Windows port, fix some resources leaks Ranier Vilela <ranier.vf@gmail.com>
Re: [PATCH] Windows port, fix some resources leaks Michael Paquier <michael@paquier.xyz>
Re: [PATCH] Windows port, fix some resources leaks Ranier Vilela <ranier.vf@gmail.com>
Re: [PATCH] Windows port, fix some resources leaks Ranier Vilela <ranier.vf@gmail.com>
Em ter., 28 de jan. de 2020 às 18:06, Alvaro Herrera <alvherre@2ndquadrant.com> escreveu:
On 2020-Jan-28, Robert Haas wrote:

> On Fri, Jan 24, 2020 at 2:13 AM Michael Paquier <michael@paquier.xyz> wrote:
> > No, that's not right.  I think that it is possible to loop over
> > ShmemProtectiveRegion in some cases.  And actually, your patch is dead
> > wrong because this is some code called by the postmaster and it cannot
> > use FATAL.
>
> Uh, really? I am not aware of such a rule.

I don't think we have ever expressed it as such, but certainly we prefer
postmaster to be super robust ... rather live with a some hundred bytes
leak rather than have it die and take the whole database service down
for what's essentially a fringe bug that has bothered no one in a decade
and a half.
Maybe it didn't bother anyone, because the Windows port is much less used.
Anyway, I believe that freeing the memory before returning false, will not bring down the service, changing the patch to LOG, instead of FATAL.
The primary error of the patch was to use FATAL.

regards,
Ranier Vilela
В списке pgsql-hackers по дате отправления
Предыдущее
От: Tom Lane
Дата:
Следующее
От: Floris Van Nee
Дата:
FAQ