[PATCH] /src/backend/access/transam/xlog.c, tiny improvements
От
Ranier Vilela
Тема
[PATCH] /src/backend/access/transam/xlog.c, tiny improvements
Дата
Msg-id
CAEudQAocMqfqt0t64HNo39Z73jMey60WmeryB+WFDg3BZpCf=g@mail.gmail.com
Список
Дерево обсуждения
[PATCH] /src/backend/access/transam/xlog.c, tiny improvements Ranier Vilela <ranier.vf@gmail.com>
Re: [PATCH] /src/backend/access/transam/xlog.c, tiny improvements Mark Dilger <mark.dilger@enterprisedb.com>
Re: [PATCH] /src/backend/access/transam/xlog.c, tiny improvements Michael Paquier <michael@paquier.xyz>
Re: [PATCH] /src/backend/access/transam/xlog.c, tiny improvements Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Re: [PATCH] /src/backend/access/transam/xlog.c, tiny improvements Ranier Vilela <ranier.vf@gmail.com>
Hi,
There are 3 tiny improvements to xlog.c code:
1. At function StartupXLOG (line 6370), the second test if (ArchiveRecoveryRequested) is redundant and can secure removed.
2. At function StartupXLOG (line 7254) the var switchedTLI already been tested before and the second test can secure removed.
3. At function KeepLogSeg (line 9357) the test if (slotSegNo <= 0), the var slotSegNo is uint64 and not can be < 0.
As it is a critical file, even though small, these improvements, I believe are welcome, because they improve readability.
regards,
Ranier Vilela
В списке pgsql-hackers по дате отправления
От: Andres Freund
Дата:
От: Julien Rouhaud
Дата:
