Re: Refactor to eliminate cast-away-const in pg_dump object sort comparator

Поиск
Список
Период
Сортировка
От Chao Li
Тема Re: Refactor to eliminate cast-away-const in pg_dump object sort comparator
Дата
Msg-id CAEoWx2=4ieNiGp0c_SLkf-FZnc1KWyrn1W1Naaprpi1L6OfUog@mail.gmail.com
обсуждение исходный текст
Ответ на Refactor to eliminate cast-away-const in pg_dump object sort comparator  (Chao Li <li.evan.chao@gmail.com>)
Ответы Re: Refactor to eliminate cast-away-const in pg_dump object sort comparator
Список pgsql-hackers
Дерево обсуждения

On Dec 24, 2025, at 09:58, Chao Li <li.evan.chao@gmail.com> wrote:

Hi Hacker,

While reviewing patch [1], I raised a comment about cast-away-const in pg_dump_sort.c. However, the comment was not accepted and the argument was that the nearby code did the same thing. 

I saw Tom recently had a commit [2] that removed some cast-away-const in ecpg, so I am filing this patch to eliminate all cast-away-const problems in pg_dump_sort.c.

[1] https://postgr.es/m/CALDaNm2x3rd7C0_HjUpJFbxpAqXgm=QtoKfkEWDVA8h+JFpa_w@mail.gmail.com
[2] https://git.postgresql.org/cgit/postgresql.git/commit/?id=4eda42e8bdf5bd3bf69576d54a45c10e7cbc3b35


I just noticed this patch does the similar thing as [3] just handling a different file. As Peter had a comment on [3], I addressed the comment as well in v2.


Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/


Вложения

В списке pgsql-hackers по дате отправления:

Чтобы сделать работу с сайтом удобнее, мы используем cookie и аналитический сервис «Яндекс.Метрика». Продолжая пользоваться сайтом, вы соглашаетесь с их использованием.