Re: [HACKERS] Fix warnings and typo in dshash

Поиск
Список
Период
Сортировка
От Thomas Munro
Тема Re: [HACKERS] Fix warnings and typo in dshash
Дата
Msg-id CAEepm=3TuBb_LKfH7+AnkD8ZKyb+Facz_=hMNoHnxCEUxEpCyw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] Fix warnings and typo in dshash  (Amit Kapila <amit.kapila16@gmail.com>)
Ответы Re: [HACKERS] Fix warnings and typo in dshash
Список pgsql-hackers
On Mon, Sep 4, 2017 at 2:18 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Sun, Sep 3, 2017 at 2:56 PM, Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
>> I think it should be (size_t) 1, not UINT64CONST(1).  See attached.
>
> Okay, that makes sense.  Do you think we should also change type
> casting in BUCKETS_PER_PARTITION so that we are consistent?

+1

Here's a patch to fix that.  I was reminded to come back and tidy this
up when I spotted a silly mistake in a nearby comment, also fixed in
this patch.

-- 
Thomas Munro
http://www.enterprisedb.com

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Sand Stone
Дата:
Сообщение: persistent read cache
Следующее
От: Andrew Dunstan
Дата:
Сообщение: Re: ALTER TABLE ADD COLUMN fast default