On Fri, Jul 20, 2018 at 8:14 PM, Oskari Saarenmaa <os@ohmu.fi> wrote:
> On Thu, Jul 12, 2018 at 01:55:31PM +1200, Thomas Munro wrote:
>> [...] I'm not even sure I'd bother adding "At" to the
>> function names. If there are any extensions that want the old
>> interface they will fail to compile either way. Note that the BufFile
>> interface remains the same, so hopefully that covers many use cases.
>
> IIRC I used the "At" suffixes in my first version of the patch before
> completely removing the functions which didn't take an offset argument
> Now that they're gone I agree that we could just drop the "At" suffix;
> "at" suffix is also used by various POSIX functions to operate in a
> specific directory which may just add to confusion.
Done. Rebased.
--
Thomas Munro
http://www.enterprisedb.com