Re: [HACKERS] valgrind vs. shared typmod registry

Поиск
Список
Период
Сортировка
От Thomas Munro
Тема Re: [HACKERS] valgrind vs. shared typmod registry
Дата
Msg-id CAEepm=2ekM7BFdpZHqsJhfrewb7FndhEPPhDQ4QnTGNgSB4tQw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] valgrind vs. shared typmod registry  (Thomas Munro <thomas.munro@enterprisedb.com>)
Ответы Re: [HACKERS] valgrind vs. shared typmod registry  (Thomas Munro <thomas.munro@enterprisedb.com>)
Список pgsql-hackers
On Sun, Sep 17, 2017 at 7:42 AM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Sun, Sep 17, 2017 at 12:30 AM, Tomas Vondra
> <tomas.vondra@2ndquadrant.com> wrote:
>> I've been running some regression tests under valgrind, and it seems
>> select_parallel triggers some uses of uninitialized values in dshash. If
>> I'm reading the reports right, it complains about hashtable->size_log2
>> being not being initialized in ensure_valid_bucket_pointers.
>
> Thanks.  Will investigate.

Yeah, it's a bug, I simply failed to initialise it.
ensure_valid_bucket_pointers() immediately fixes the problem (unless
the uninitialised memory had an unlikely value), explaining why it
works anyway.  I'm a bit tied up today but will test and post a patch
tomorrow.

-- 
Thomas Munro
http://www.enterprisedb.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: [HACKERS] Re: [COMMITTERS] pgsql: Perform only oneReadControlFile() during startup.
Следующее
От: David Rowley
Дата:
Сообщение: Re: [HACKERS] [GENERAL] Remove useless joins (VARCHAR vs TEXT)