Re: dsa_allocate() faliure

On Mon, Feb 11, 2019 at 10:33 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I observe from
>
> https://coverage.postgresql.org/src/backend/utils/mmgr/freepage.c.gcov.html
>
> that the edge cases in this function aren't too well exercised by
> our regression tests, meaning that the buildfarm might not prove
> much either way about the correctness of this patch.  That is one
> factor pushing me to think we shouldn't risk it.  But, taking a
> longer view, is that something that's practical to improve?

Yeah.  This is a nice example of code that really deserves unit tests
written in C.  Could be good motivation to built the infrastructure I
mentioned here:

https://www.postgresql.org/message-id/flat/CAEepm%3D2heu%2B5zwB65jWap3XY-UP6PpJZiKLQRSV2UQH9BmVRXQ%40mail.gmail.com

-- 
Thomas Munro
http://www.enterprisedb.com