On Fri, Aug 24, 2018 at 11:35 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, Aug 24, 2018 at 03:32:28PM +1200, Thomas Munro wrote:
> Thanks for considering it. I have not gone in details through the patch
> but...
>
> + (codepoint.id >= ord('A') and codepoint.id <= ord('Z')) or \
> + (codepoint.id >= 0x03b1 and codepoint.id <= 0x03c9) or \
> + (codepoint.id >= 0x0391 and codepoint.id <= 0x03a9)
>
> ... If you could add notes about what those codepoints are, or just
> allocate them in a variable with a proper name, that would help with the
> readability. My apologies for the nits on this thread.
Fair criticism, here's a version with comments.
--
Thomas Munro
http://www.enterprisedb.com