Re: Incorrect comment in postgres_fdw.c

Поиск
Список
Период
Сортировка
От Shigeru Hanada
Тема Re: Incorrect comment in postgres_fdw.c
Дата
Msg-id CAEZqfEfBpJP+kNBeOuaB-B_euBWHJR_EhXsgST5fmf1dZLLxdg@mail.gmail.com
обсуждение исходный текст
Ответ на Incorrect comment in postgres_fdw.c  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Ответы Re: Incorrect comment in postgres_fdw.c  (Fujii Masao <masao.fujii@gmail.com>)
Список pgsql-hackers
Fujita-san,

2014-07-11 18:22 GMT+09:00 Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>:
> I think the following comment for store_returning_result() in
> postgres_fdw.c is not right.
>
>     /* PGresult must be released before leaving this function. */
>
> I think PGresult should not be released before leaving this function *on
> success* in that function.
>
> (I guess the comment has been copied and pasted from that for
> get_remote_estimate().)

+1 for just removing the comment, because header comment clearly
mentions necessity of releasing the PGresult.


-- 
Shigeru HANADA



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Abhijit Menon-Sen
Дата:
Сообщение: Re: pg_shmem_allocations view
Следующее
От: Kyotaro HORIGUCHI
Дата:
Сообщение: Re: Use unique index for longer pathkeys.