Re: Improving and extending int128.h to more of numeric.c

On Fri, 24 Oct 2025 at 20:30, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>
> On Fri, 24 Oct 2025 at 15:23, Andres Freund <andres@anarazel.de> wrote:
> >
> > FWIW, there are a few interesting messages on the host of my buildfarm animal:
> >
> > Aug 19 02:05:31 andres-postgres-buildfarm-v6 kernel: traps: test_int128[1678696] trap divide error ip:55764d59802c
sp:7fffc378f7f8error:0 in test_int128[402c,55764d595000+4000]
 
> > Oct 15 03:08:28 andres-postgres-buildfarm-v6 kernel: traps: test_int128[1984641] trap divide error ip:405a8c
sp:7ffc41a93c88error:0 in test_int128[5a8c,401000+5000]
 
> > Oct 15 20:02:15 andres-postgres-buildfarm-v6 kernel: traps: test_int128[3346617] trap divide error ip:404b4c
sp:7ffc709ab658error:0 in test_int128[4b4c,401000+4000]
 
> >
>
> Ah, I presume this is because there is a small, but non-zero chance
> that the test code will attempt to divide by zero, so it needs to make
> sure that z32 is non-zero. Will fix.

I was able to produce a division-by-zero failure by running the full 1
billion iteration test a few times, and I've pushed a fix for it.

Regards,
Dean