On 5 July 2013 18:23, David Fetter <david@fetter.org> wrote:
> Please find attached changes based on the above.
>
This looks good. The grammar changes are smaller and neater now on top
of the makeFuncCall() patch.
Overall I think this patch offers useful additional functionality, in
compliance with the SQL spec, which should be handy to simplify
complex grouping queries.
There's a minor typo in syntax.sgml: "for each input row, each row
matching same." --- fix attached.
I think this is ready for committer.
Regards,
Dean