Re: remove WITHOUT OIDS syntax for v19

On Tue, Jul 15, 2025 at 11:11 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Junwang Zhao <zhjwpku@gmail.com> writes:
> > WITH OIDS was removed in v12, I'm wondering if we could remove the
> > WITHOUT OIDS support for v19.
>
> Why?

Sorry I didn't mention the reason why I think WITHOUT OIDS should be removed.

WITHOUT OIDS has been a backward-compatible syntax for 6 years, so I
think maybe not too many users use it nowadays. Besides, there are
some hints in the code base that `WITHOUT OIDS` and `with (oids =
false)` will be removed someday(see the following diff), so I wonder
which day should it be?

-/* WITHOUT OIDS is legacy only */
 OptWith:
                        WITH reloptions                         { $$ = $2; }
-                       | WITHOUT OIDS                          { $$ = NIL; }
                        | /*EMPTY*/

-                       /*
-                        * This is not a great place for this test,
but there's no other
-                        * convenient place to filter the option out.
As WITH (oids =
-                        * false) will be removed someday, this seems
like an acceptable
-                        * amount of ugly.
-                        */

>
>                         regards, tom lane



--
Regards
Junwang Zhao