Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length

Поиск
Список
Период
Сортировка
От Junwang Zhao
Тема Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length
Дата
Msg-id CAEG8a3KWE9bdOaVVrD22HtF93QTG27vdqfJ=BxEMCFKb1R_eUQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length  (David Rowley <dgrowleyml@gmail.com>)
Ответы Re: Adjust comments for `IndexOptInfo` to accurately reflect indexcollations's length
Список pgsql-hackers
On Mon, Nov 24, 2025 at 6:52 AM David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Sun, 23 Nov 2025 at 01:44, Junwang Zhao <zhjwpku@gmail.com> wrote:
> > Length of indexcollations[] in `IndexOptInfo` is nkeycolumns, but
> > struct comments fail to express this, it says:
> >
> > indexkeys[], indexcollations[] each have ncolumns entries.
> >
> > So we should polish this description. trivial patch attached.
>
> Thanks. I agree with the patch.  We should probably mention
> canreturn[] too. I can take care of this.

Agreed. Thanks for taking care of this.

>
> David



--
Regards
Junwang Zhao



В списке pgsql-hackers по дате отправления: