Re: A WalSnd issue related to state WALSNDSTATE_STOPPING

Поиск
Список
Период
Сортировка
От Paul Guo
Тема Re: A WalSnd issue related to state WALSNDSTATE_STOPPING
Дата
Msg-id CAEET0ZFr00MLhC-auSfszZ+LrbV5H1N0VNqeCn8oJ7PQbW9joA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: A WalSnd issue related to state WALSNDSTATE_STOPPING  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: A WalSnd issue related to state WALSNDSTATE_STOPPING  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Thu, Nov 22, 2018 at 06:31:04PM +0800, Paul Guo wrote:
> Yes, please see the attached patch.

Thanks, I have reviewed your patch, and could not resist to change
SyncRepReleaseWaiters() on top of the rest with a comment to not be
confused about the WAL sender states allowed to release waiters.

The previous experience is proving that it seems unwise to rely on the
order of the elements in WalSndState, so I have tweaked things so as the
state is listed for all the code paths involved.

Paul, what do you think?
--
Michael

Agree. Your code change is safer.
 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: Pluggable Storage - Andres's take
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: [HACKERS] Block level parallel vacuum