Re: [HACKERS] pageinspect: Hash index support

Поиск
Список
Период
Сортировка
От Ashutosh Sharma
Тема Re: [HACKERS] pageinspect: Hash index support
Дата
Msg-id CAE9k0PnKFEk+nFQU+fCDpiNf0VZzFSskK-vozFEBzVbt7Mw6Sw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] pageinspect: Hash index support  (Mithun Cy <mithun.cy@enterprisedb.com>)
Ответы Re: [HACKERS] pageinspect: Hash index support  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Thanks for reporting it. This is because of incorrect data typecasting. Attached is the patch that fixes this issue.

On Tue, Feb 21, 2017 at 2:58 PM, Mithun Cy <mithun.cy@enterprisedb.com> wrote:
On Fri, Feb 10, 2017 at 1:06 AM, Robert Haas <robertmhaas@gmail.com> wrote:

> Alright, committed with a little further hacking.

I did pull the latest code, and tried
Test:
====
create table t1(t int);
create index i1 on t1 using hash(t);
insert into t1 select generate_series(1, 10000000);

postgres=# SELECT spares FROM hash_metapage_info(get_raw_page('i1', 0));
                                   spares
----------------------------------------------------------------------------
 {0,0,0,1,9,17,33,65,-127,1,1,0,1,-1,-1,-4,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0}

spares are showing negative numbers; I think the wrong type has been
chosen, seems it is rounding at 127, spares are defined as following
uint32 hashm_spares[HASH_MAX_SPLITPOINTS]; /* spare pages before each
splitpoint */

it should be always positive.

--
Thanks and Regards
Mithun C Y
EnterpriseDB: http://www.enterprisedb.com

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Mithun Cy
Дата:
Сообщение: Re: [HACKERS] pageinspect: Hash index support
Следующее
От: Mithun Cy
Дата:
Сообщение: Re: [HACKERS] [POC] A better way to expand hash indexes.