Re: [PATCH] Improve geometric types

Поиск
Список
Период
Сортировка
От Emre Hasegeli
Тема Re: [PATCH] Improve geometric types
Дата
Msg-id CAE2gYzyM=xKr-AoBakj1GHh_1Vv9iQ+KqKsdMvckiZ2GbV4ZfQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Improve geometric types  (Thomas Munro <thomas.munro@enterprisedb.com>)
Ответы Re: [PATCH] Improve geometric types  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Список pgsql-hackers
> Those underscore-prefixed names are defined in Microsoft's
> <float.h>[3][4].  So now I'm wondering if win32_port.h needs to
> #include <float.h> if (_MSC_VER < 1800).

I don't have the C experience to decide the correct way.  There are
currently many .c files that are including float.h conditionally or
unconditionally.  The condition they use is "#ifdef _MSC_VER" without
a version.

One idea is to include float.h from the new utils/float.h file
together with math.h, and remove those includes from the .c files
which would include utils/float.h.  We can do this only, or together
with what you suggest, or by also keeping the includes on the .c
files.  Which way do you think is the proper?


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: buildfarm vs code
Следующее
От: "MauMau"
Дата:
Сообщение: Re: I'd like to discuss scaleout at PGCon