Re: [HACKERS] [PATCH] Remove trailing whitespaces from documentation

Поиск
Список
Период
Сортировка
От Vladimir Rusinov
Тема Re: [HACKERS] [PATCH] Remove trailing whitespaces from documentation
Дата
Msg-id CAE1wr-xkPYADa2xiU8t-2DpuVxE6DS2x_SbT4m=Y9in_K0dHVg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] [PATCH] Remove trailing whitespaces from documentation  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers



On Wed, Dec 14, 2016 at 5:14 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Stephen Frost <sfrost@snowman.net> writes:
> If we do want to change that, perhaps we should also change psql to not
> output the trailing whitespace in the first place..?

Yeah, maybe.  I seem to recall having looked at that a long time ago
and deciding that it wasn't worth the trouble, but the code involved
has probably been restructured since then, so maybe it'd be easier now.
 
That sounds like a good idea, I guess I can take another look.
I could think of no reason to keep whitespaces there.

Of course, that would also create a back-patch breakpoint for every
single regression test expected-file, which is doubling down on the
PITA factor in a rather major way.

It looks like tests (at least in master) ignore whitespace-only diffs.
So we can handle trailing whitespaces in expected output files as a separate issue.
One way to ease the pain is to remove trailing whitespaces in all supported branches via separate patches.

-- 
Vladimir Rusinov
Storage SRE, Google Ireland

Google Ireland Ltd.,Gordon House, Barrow Street, Dublin 4, Ireland
Registered in Dublin, Ireland
Registration Number: 368047

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Stephen Frost
Дата:
Сообщение: Re: [HACKERS] [PATCH] Remove trailing whitespaces from documentation
Следующее
От: Stephen Frost
Дата:
Сообщение: Re: [HACKERS] [PATCH] Remove trailing whitespaces from documentation