Re: [pgAdmin4][RM#3129] handle encoding issue in File manager
Hello Murtuza,
The code looks pretty good, love the fact that you extracted it so that our file size stop growing and get more manageable. All tests pass on our CI.
The only issue I found was linting:
pycodestyle --config=.pycodestyle pgadmin/tools/sqleditor/
pgadmin/tools/sqleditor/utils/query_tool_fs_utils.py:12: [E302] expected 2 blank lines, found 1
pgadmin/tools/sqleditor/utils/query_tool_fs_utils.py:53: [W391] blank line at end of file
pgadmin/tools/sqleditor/utils/tests/test_query_tool_fs_utils.py:27: [E121] continuation line under-indented for hanging indent
pgadmin/tools/sqleditor/utils/tests/test_query_tool_fs_utils.py:29: [E122] continuation line missing indentation or outdented
1 E121 continuation line under-indented for hanging indent
1 E122 continuation line missing indentation or outdented
1 E302 expected 2 blank lines, found 1
1 W391 blank line at end of file
4
When this is fixed I think we are good to go
Thanks
Joao
On Thu, Mar 1, 2018 at 3:01 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA patch to fix the issue where user was not able to open the file with non utf-8 encoding.--Regards,
В списке pgadmin-hackers по дате отправления:
Предыдущее
От: Joao De Almeida PereiraДата:
Сообщение: Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query
Следующее
От: Murtuza ZabuawalaДата:
Сообщение: Re: [pgAdmin4][RM#3129] handle encoding issue in File manager