Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayedwhen user try to insert data on table where primray key is in captial lettersand table contains OIDS

Поиск
Список
Период
Сортировка
От Joao De Almeida Pereira
Тема Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayedwhen user try to insert data on table where primray key is in captial lettersand table contains OIDS
Дата
Msg-id CAE+jjamqaZT31xVa5o+eQtxMh5t3affFuNgKFhbfJZyGaaf7SQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayedwhen user try to insert data on table where primray key is in captial lettersand table contains OIDS  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Ответы Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayedwhen user try to insert data on table where primray key is in captial lettersand table contains OIDS  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Hello Khushboo,

All tests pass on CI, and the code looks good. The only issue that I found was the line:
 os.path.dirname(os.path.realpath(__file__)) + "/../templates"

that will not work on windows. 
So I updated your patch with the change and it should be ready to merge.


Thanks
Joao

On Tue, Mar 6, 2018 at 7:33 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Joao,

Thanks for reviewing.

On Thu, Mar 1, 2018 at 8:06 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Kushboo,

Can we add some Unit test to ensure this does not happen again?

Please find the attached patch with the unit tests. 
Thanks
Joao

Thanks,
Khushboo 
On Thu, Mar 1, 2018 at 2:28 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix RM # 3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS

Thanks,
Khushboo
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Joao De Almeida Pereira
Дата:
Сообщение: Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query
Следующее
От: Joao De Almeida Pereira
Дата:
Сообщение: Re: [pgAdmin4][RM#2989] To fix the issue in Table node