Re: Bug #2309 fix

Поиск
Список
Период
Сортировка
От Joao De Almeida Pereira
Тема Re: Bug #2309 fix
Дата
Msg-id CAE+jjamYZfYvwqjonCsO_A5FNP-EuSzXNEdR8sk34hCNC3sUKA@mail.gmail.com
обсуждение исходный текст
Ответ на Bug #2309 fix  (Neethu Mariya Joy <neethumariyajoy@gmail.com>)
Ответы Re: Bug #2309 fix  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Re: Bug #2309 fix  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Hello Neethu,

We run the patch though our test pipeline and all tests are green. Everything looks good with this patch

Thanks
Joao
On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy <neethumariyajoy@gmail.com> wrote:
Hi,
I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer Science at BITS Pilani.

I've attempted to fix https://redmine.postgresql.org/issues/2309. Codemirrors catches all the keyboard and mouse events when 'readOnly' option is set to 'noCursor' and does not allow copying.
So, I've set 'readOnly' option to true. In order to hide the cursor, I've added a class 'hide-cursor-workaround' and applied css styles to hide the cursor.

I'm attaching my patch as bug2309.diff below as per the contribution guidelines.

Hope this helps. Thank you for your consideration!

Sincerely,
Neethu Mariya Joy

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Neethu Mariya Joy
Дата:
Сообщение: Re: Feature #3061
Следующее
От: Joao De Almeida Pereira
Дата:
Сообщение: Re: Bug #3083 fix