Re: Race conditions in logical decoding

On Tue, Jan 20, 2026 at 6:50 PM Andres Freund <andres@anarazel.de> wrote:
> I don't think that's enough - during non-timetravel visibility semantics, you
> can only look at the clog if the transaction isn't marked as in-progress in
> the procarray.  ISTM that we need to do that here too?

Do you mean replace

> if (unlikely(!TransactionIdDidCommit(builder->committed.xip[i])))

to
> if (unlikely(TransactionIdIsInProgress(builder->committed.xip[i]) || !TransactionIdDidCommit(builder->committed.xip[i])))

?

If so, yes, it feels correct to me.

Mikhail.