2011/10/10 Robert Haas <robertmhaas@gmail.com>:
> On Wed, Oct 5, 2011 at 2:58 PM, Kohei KaiGai <kaigai@kaigai.gr.jp> wrote:
>> Hmm. It indeed makes translation hard.
>> I reverted this portion of the part-2 patch, as attached.
>> Please review the newer one, instead of the previous revision.
>
> Please fix the compiler warnings.
>
I checked compiler warnings using COPT=-Werror, but it detects warning on
only unrelated files as below. Does it really come from my patches?
(Does it depend on ./configure options?)
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Wendif-labels
-Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
-fwrapv -g -Werror -I../../../src/include -D_GNU_SOURCE -c -o
execQual.o execQual.c
execQual.c: In function ‘GetAttributeByNum’:
execQual.c:1104:67: error: the comparison will always evaluate as
‘true’ for the address of ‘tmptup’ will never be NULL
[-Werror=address]
execQual.c: In function ‘GetAttributeByName’:
execQual.c:1165:67: error: the comparison will always evaluate as
‘true’ for the address of ‘tmptup’ will never be NULL
[-Werror=address]
execQual.c: In function ‘ExecEvalFieldSelect’:
execQual.c:3914:67: error: the comparison will always evaluate as
‘true’ for the address of ‘tmptup’ will never be NULL
[-Werror=address]
cc1: all warnings being treated as errors
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Wendif-labels
-Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
-fwrapv -g -Werror -I../../../../src/include -D_GNU_SOURCE -c -o
tuplesort.o tuplesort.c
tuplesort.c: In function ‘comparetup_heap’:
tuplesort.c:2751:66: error: the comparison will always evaluate as
‘true’ for the address of ‘ltup’ will never be NULL [-Werror=address]
tuplesort.c:2752:66: error: the comparison will always evaluate as
‘true’ for the address of ‘rtup’ will never be NULL [-Werror=address]
tuplesort.c: In function ‘copytup_heap’:
tuplesort.c:2783:71: error: the comparison will always evaluate as
‘true’ for the address of ‘htup’ will never be NULL [-Werror=address]
tuplesort.c: In function ‘readtup_heap’:
tuplesort.c:2835:71: error: the comparison will always evaluate as
‘true’ for the address of ‘htup’ will never be NULL [-Werror=address]
cc1: all warnings being treated as errors
Thanks,
--
KaiGai Kohei <kaigai@kaigai.gr.jp>