Re: Tab completion for CREATE SEQUENCE

От

Brendan Jurd

Тема

Дата

19 июня 2015 г. в 06:41:34

Msg-id

CADxJZo0cnwYd2sEeHx1ogQ3XqwwnwJU_WJ2+N_W5Qkxu=a3baQ@mail.gmail.com

обсуждение

Ответ на

Tab completion for CREATE SEQUENCE (Vik Fearing)

Список

pgsql-hackers

Дерево обсуждения

Tab completion for CREATE SEQUENCE Vik Fearing <vik@2ndquadrant.fr> 15 июня 2015 г. в 14:51:47

Re: Tab completion for CREATE SEQUENCE Brendan Jurd <direvus@gmail.com> 19 июня 2015 г. в 06:41:34

Re: Tab completion for CREATE SEQUENCE Andres Freund <andres@anarazel.de> 7 июля 2015 г. в 12:14:41

Re: Tab completion for CREATE SEQUENCE Michael Paquier <michael.paquier@gmail.com> 3 августа 2015 г. в 06:17:26

Re: Tab completion for CREATE SEQUENCE Robert Haas <robertmhaas@gmail.com> 4 августа 2015 г. в 16:30:18

Re: Tab completion for CREATE SEQUENCE Vik Fearing <vik@2ndquadrant.fr> 12 августа 2015 г. в 13:22:48

Re: Tab completion for CREATE SEQUENCE Robert Haas <robertmhaas@gmail.com> 12 августа 2015 г. в 16:09:25

On Tue, 16 Jun 2015 at 00:52 Vik Fearing <vik@2ndquadrant.fr> wrote:

While reviewing the seqam patches, I noticed that psql has tab
completion for ALTER SEQUENCE, but not for CREATE SEQUENCE.

The attached trivial patch fixes that.

Hi Vik,

I'm doing an initial review of this patch.

It applies cleanly, although for some reason the patch seems to introduce carriage returns in the line endings. `patch` warned about those and then very sensibly ignored them. Everything compiled fine after applying.

The new code's style is not quite in accordance with the surrounds. I think that the comments introducing each section should be de-indented to the first column.

"RESTART", "SET SCHEMA", "OWNER TO", and "RENAME TO" are not valid completions for CREATE SEQUENCE. It looks like these have been blindly copy-pasted from ALTER SEQUENCE. Likewise, the valid completion "START [WITH]" is missing.

"CREATE TEMP[ORARY] SEQUENCE" is not supported, and I think it probably should be. I think that the patch could be improved with support for the TEMP form fairly easily.

Apart from the above points, the new completions worked as advertised.

Docs: none needed.

Tests: we don't currently have any test coverage for psql tab completion.

I'm marking this "Waiting on Author". Once the problems have been corrected, it should be ready for a committer.

Cheers,

В списке pgsql-hackers по дате отправления

Предыдущее

От: Michael Paquier

Дата: 19 июня 2015 г. в 06:33:16

Сообщение: pg_regress not waiting for postmaster to stop

Следующее

От: Brendan Jurd

Дата: 19 июня 2015 г. в 07:09:04

Сообщение: Re: Tab completion for TABLESAMPLE