Re: [PATCH] Use strchr() to search for a single character
| От | Corey Huinker |
|---|---|
| Тема | Re: [PATCH] Use strchr() to search for a single character |
| Дата | |
| Msg-id | CADkLM=eZe5qp+_6ZifQhxYtvhYOTr-AydsWvXhPe2mZs=9npTw@mail.gmail.com обсуждение исходный текст |
| Ответ на | [PATCH] Use strchr() to search for a single character (Dmitry Mityugov <d.mityugov@postgrespro.ru>) |
| Ответы |
Re: [PATCH] Use strchr() to search for a single character
|
| Список | pgsql-hackers |
On Sun, Jul 20, 2025 at 6:21 PM Dmitry Mityugov <d.mityugov@postgrespro.ru> wrote:
Code in src/port/pgmkdirp.c uses strstr() to find a single character in
a string, but strstr() seems to be too generic for this job. Another
function, strchr(), might be better suited for this purpose, because it
is optimized to search for exactly one character in a string. In
addition, if strchr() is used, the compiler doesn't have to generate a
terminating \0 byte for the substring, producing slightly smaller code.
I'm attaching the patch.
Regards,
Dmitry
Seems like a simple-enough change, not a huge win but probably worth doing.
Using ripgrep to search for 'strstr(.*".")' turns up two similar situations in contrib/fuzzystrmatch/dmetaphone.c, so perhaps we include those.
There's also a match in src/bin/pg_rewind/filemap.c, but that one is a false positive.
В списке pgsql-hackers по дате отправления: