Re: vacuumdb: add --dry-run
| От | Corey Huinker |
|---|---|
| Тема | Re: vacuumdb: add --dry-run |
| Дата | |
| Msg-id | CADkLM=dwBjL5fK-Dq_2qhAuHsHPab_Kt+R7KZTA9w_X0K6bENg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: vacuumdb: add --dry-run (Nathan Bossart <nathandbossart@gmail.com>) |
| Ответы |
Re: vacuumdb: add --dry-run
|
| Список | pgsql-hackers |
On Wed, Nov 19, 2025 at 5:44 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
On Wed, Nov 19, 2025 at 05:23:48PM -0500, Corey Huinker wrote:
> Now with zero hangs and some test cases. I didn't create a function (yet)
> as it seemed trivial.
I still think it could be worth moving the dry-run code into
run_vacuum_command() (which might entail moving the calls to
ParallelSlotSetHandler() there, too). We can probably piggy-back on the
"if (echo)" branch in that function.
We _could_ get away with moving ParallelSlotGetIdle() in there too. The only catch would be that we'd have to refactor prepare_vacuum_command() to take a serverVersionNumber parameter instead of the whole connection. Thoughts?
Also, we can probably skip the executeCommand() calls for
--analyze-in-stages.
+1
В списке pgsql-hackers по дате отправления: