On Tue, Jan 15, 2019 at 10:17 AM Shay Rojansky <roji@roji.org> wrote: > Unfortunately I'm extremely tight for time at the moment and don't have time to do the appropriate hot standby setup to test this... As the patch is pretty straightforward, and since I'm hoping you guys execute the tests on your end, I hope that's acceptable. If it's absolutely necessary for me to test the patch locally, let me know and I'll do so.
I would definitely prefer if you could run the tests. You might discover that your patch does not sufficiently address tests. Please do so and confirm here that it works for you and then I can do another review.
Thanks for insisting - I ended up setting up the environment and running the tests, and discovering that some test-related changes were missing. Here's a 3rd version of the patch. Hope this is now in good shape, let me know if you think anything else needs to be done.