Wrong dead return value in jsonb_utils.c

Поиск
Список
Период
Сортировка
От Rikard Falkeborn
Тема Wrong dead return value in jsonb_utils.c
Дата
Msg-id CADRDgG7mJnek6HNW13f+LF6V=6gag9PM+P7H5dnyWZAv49aBGg@mail.gmail.com
обсуждение исходный текст
Ответы Re: Wrong dead return value in jsonb_utils.c  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Returning -1 from a function with bool as return value is the same as returning true. Now, the code is dead (since elog(ERROR, ...) does not return) so it doesn't matter to the compiler, but changing to false is less confusing for the programmer. Appologies if this is seen as unnecessary churn.

The same code is present since 9.4, but perhaps it's not really worth backporting since it is more of an aesthetic change?
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: Bug in reindexdb's error reporting
Следующее
От: Noah Misch
Дата:
Сообщение: Re: Augment every test postgresql.conf