On 25 June 2014 08:13, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Wed, Jun 25, 2014 at 1:29 PM, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:
>> The patch looks OK, and works as advertised (I tested on Linux). If we
>> want the feature (I like it), this patch is a good enough way to get it.
>
> I got the following compiler warning.
>
> guc.c:3099: warning: initialization from incompatible pointer type
Thank you both for your reviews. Please find attached an updated v5
patch (based on Abhijit's rebased and improved version) which fixes
the compiler warning. (The previous unusual and possibly incorrect
static initialization with a string literal was intended to make sure
logging would work before the GUC machinery has finished setting up
default values, but that no longer applies.)
Regards,
Thomas Munro