Re: [HACKERS] [PATCH] Push limit to sort through a subquery

Поиск
Список
Период
Сортировка
От Douglas Doole
Тема Re: [HACKERS] [PATCH] Push limit to sort through a subquery
Дата
Msg-id CADE5jY+BOPdtzR1H0GtNqE2hf3D-eCEiS6_-esmVt4XtZf-kDg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] [PATCH] Push limit to sort through a subquery  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: [HACKERS] [PATCH] Push limit to sort through a subquery  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
1. The header comment for pass_down_bound() could mention "one or more
levels of subqueries" rather than "a subquery".

Fixed 

2. The first of the comments in the function body appears to have a
whitespace issue that needs to be fixed manually or, better yet,
addressed by pgindent.

Fixed
 
3. The formatting of the comment in the regression tests appears to be
unlike any other comment in that same file.

A side effect of inheriting it from our branches ;-) Reworked.
 
4. I am pretty doubtful that "Memory: 25kB" is going to be stable
enough for us to want that output memorialized in the regression ...

Fair enough. I wanted to be a bit more sophisticated in my check than looking for a single value so I worked out something that distills the explain down to the key elements.
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: [HACKERS] expanding inheritance in partition bound order
Следующее
От: Pavel Stehule
Дата:
Сообщение: Re: [HACKERS] possible encoding issues with libxml2 functions