Re: pgsql: Fix our Windows stat() emulation to handle file sizes > 4GB.
| От | Andrew Dunstan |
|---|---|
| Тема | Re: pgsql: Fix our Windows stat() emulation to handle file sizes > 4GB. |
| Дата | |
| Msg-id | CAD5tBcJ2EJ9=Na1A6N3xHMVYwBAyjZ+pnC5MEXRfxK963XtDAw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: pgsql: Fix our Windows stat() emulation to handle file sizes > 4GB. (Tom Lane <tgl@sss.pgh.pa.us>) |
| Ответы |
Re: pgsql: Fix our Windows stat() emulation to handle file sizes > 4GB.
|
| Список | pgsql-committers |
On Sat, Nov 9, 2024 at 2:33 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Nov 7, 2024 at 6:19 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>> Juan José Santamaría Flecha, reviewed by Emil Iggland;
>> based on prior work by Michael Paquier, Sergey Zubkovsky, and others
>>
>> Author: Alexandra Wang <alexandra.wang.oss@gmail.com>
> This authorship information is confusing.
Yes. Worse, there is no link to what prompted this sudden burst
of back-patches of years-old commits. After digging around I guess
it was this thread:
https://www.postgresql.org/message-id/flat/CA%2BpA0kLc5VxOaO4WfLjmh7W0V%2BquVvVtT5CaRVRAZMuh0zft4Q%40mail.gmail.com
Right. I meant to add that link to the commit messages. Mea culpa.
Alexandra isn't the original author of these patches, but she did the work to determine exactly what needed to be backpatched, and tested it. I figured that was worth an Author credit. There didn't seem to be some other appropriate tag.
I'm nervous about pushing these in mere hours before a release freeze,
primarily because there's no way to be sure whether any necessary
follow-up fixes got missed. If we were unwilling to back-patch at
the time, is reversing that decision such a good idea?
My impression was that this was something we just didn't get around to. I wouldn't have pushed these so close to release if this hadn't been code already tested for a long time in release 16+. Maybe we missed something, but I doubt it.
cheers
andrew
В списке pgsql-committers по дате отправления: