Re: [BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format

Поиск
Список
Период
Сортировка
От Masahiko Sawada
Тема Re: [BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format
Дата
Msg-id CAD21AoDynu2TmPY-1FerBjb5nmQr1cswtfqZce_7QYYX6yJPBA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [BUGS] BUG #14775: Incorrect documentation for the Commit logicalreplication message format  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Список pgsql-bugs
On Tue, Aug 15, 2017 at 2:45 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> On 8/10/17 04:21, Masahiko Sawada wrote:
>>> The Commit message format is incorrectly documented. The `flags` field[0] is
>>> missing. I ran into this while creating a parser for the messages in
>>> Golang.
>>>
>>> [0]
>>> https://github.com/postgres/postgres/blob/master/src/backend/replication/logical/proto.c#L80
>>>
>>
>> Thank you for reporting. Yeah, it's not used actually for now but
>> should be documented. Attached patch.
>
> Committed, thanks!
>

Thank you for committing!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

В списке pgsql-bugs по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values
Следующее
От: Noah Misch
Дата:
Сообщение: Re: [BUGS] [postgresql 10 beta3] unrecognized node type: 90