On Thu, Apr 30, 2015 at 6:31 AM, David Steele <david@pgmasters.net> wrote:
> On 4/29/15 5:16 PM, Robert Haas wrote:
>> On Fri, Apr 24, 2015 at 2:40 PM, David Steele <david@pgmasters.net> wrote:
>>> <para>
>>> The view <structname>pg_file_settings</structname> provides access to
>>> run-time parameters
>>> that are defined in configuration files via SQL. In contrast to
>>> <structname>pg_settings</structname> a row is provided for each
>>> occurrence
>>> of the parameter in a configuration file. This is helpful for
>>> discovering why one value
>>> may have been used in preference to another when the parameters were
>>> loaded.
>>> </para>
>>
>> This seems to imply that this gives information about only a subset of
>> configuration files; specifically, those auto-generated based on SQL
>> commands - i.e. postgresql.conf.auto. But I think it's supposed to
>> give information about all configuration files, regardless of how
>> generated. Am I wrong? If not, I'd suggest "run-time parameters that
>> are defined in configuration files via SQL" -> "run-time parameters
>> stored in configuration files".
>
> The view does give information about all configuration files regardless
> of how they were created.
>
> That's what I intended the text to say but I think your phrasing is clearer.
>
Thank you for reviewing.
I agree with this.
Attached patch is updated version v10.
Regards,
-------
Sawada Masahiko