On Sat, Jul 21, 2018 at 6:26 PM, Sergei Kornilov <sk@zsrv.org> wrote:
> Hello
>
>> Yes, a bit more verbosity would be nice for that. Using the term
>> "anti-wraparound" directly in the logs makes the most sense?
> I used "(to prevent wraparound)" to looks like reporting in pg_stat_activity. As far i can see currently we not using
"anti-wraparound"for user messages.
> On the other hand we using anti-wraparound in docs, so i can change wording.
+1 for "to prevent wraparound".
>
>> The patch could be made simpler by using empty strings with a single
>> ereport() call.
> How about proper translate in this case? Currently we translate full line "automatic vacuum of table \"%s.%s.%s\":
indexscans: %d\n" before ereport call.
>
Yeah, for translation I think it's better to make full lines. When we
added "aggressive" to autovacuum logs (commit b55509) we've done the
same thing.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center