Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE
| От | Masahiko Sawada |
|---|---|
| Тема | Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE |
| Дата | |
| Msg-id | CAD21AoBDTwy9dSm+o8uOT2iWrSWaMELm8h-fohom1qmjaAZz3g@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE (Tatsuya Kawata <kawatatatsuya0913@gmail.com>) |
| Ответы |
Re: [PATCH] Add memory usage reporting to VACUUM VERBOSE
|
| Список | pgsql-hackers |
On Mon, Dec 29, 2025 at 7:24 PM Tatsuya Kawata <kawatatatsuya0913@gmail.com> wrote: > > Hi Sawada-san and Chao-san, > > Thank you both for your continued reviews and feedback on this patch.I agree with both points that could be misleading. > I've updated the message as follows: > > memory usage: dead item storage %.2f MB accumulated across %d resets (limit %.2f MB each) > > This wording: > - Use both "memory usage:" prefix and "dead item storage" to be consistent with other existing log lines (buffer usage:,WAL usage:, system usage:) and to clarify what kind of memory we're reporting > - Clearly indicate that the value is a cumulative sum of snapshots, not actual memory allocation > - Use "across %d resets" to show the relationship between the accumulated value and reset count > - Keep "limit %.2f MB each" to indicate the per-reset memory limit > > Please find attached the v11 patch. > The patch looks good to me, so I've pushed the patch. Kawata-san, my apologies, I missed to credit your name as the author. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
В списке pgsql-hackers по дате отправления: