On Wed, Nov 17, 2021 at 1:58 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Nov 17, 2021 at 9:13 AM houzj.fnst@fujitsu.com
> <houzj.fnst@fujitsu.com> wrote:
> >
> > On Tues, Nov 16, 2021 2:31 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > 2)
> > + <row>
> > + <entry role="catalog_table_entry"><para role="column_definition">
> > + <structfield>subrelid</structfield> <type>oid</type>
> > + </para>
> > + <para>
> > + OID of the relation that the worker is synchronizing; null for the
> > + main apply worker
> > + </para></entry>
> > + </row>
> >
> > Is the 'subrelid' only used for distinguishing the worker type ?
> >
>
> I think it will additionally tell which table sync worker as well.
Right.
>
> > If so, would it
> > be clear to have a string value here. I recalled the previous version patch has
> > failure_source column but was removed. Maybe I missed something.
> >
>
> I also don't remember the reason for this but like to know.
I felt it's a bit redundant. Setting subrelid to NULL already means
that it’s an entry for a tablesync worker. If users want the value
like “apply” or “tablesync” for each entry, they can use the subrelid
value.
> I am also reviewing the latest version of the patch and will share
> comments/questions sometime today.
Thanks!
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/