Review for pg_dump: Sort overloaded functions in deterministic order

Поиск
Список
Период
Сортировка
От Joachim Wieland
Тема Review for pg_dump: Sort overloaded functions in deterministic order
Дата
Msg-id CACw0+10=JN6jHQxhVZ1UhmLEgOXNyn0iZXdZmQxj309xn0ZMrQ@mail.gmail.com
обсуждение исходный текст
Список pgsql-hackers
Patch looks good, all concerns that had been raised previously have
been addressed in this version of the patch.

The only thing that IMO needs to change is a stylistic issue:

if (fout->remoteVersion >= 80200)
{   [...]   (fout->remoteVersion >= 80400) ?
"pg_catalog.pg_get_function_identity_arguments(oid)" : "NULL::text",   [...]
}

Please just create a whole new

if (fout->remoteVersion >= 80400)
{  [...]
}

here.

Other than that, the feature works as advertised and does not
negatively affect runtime or memory consumption (the new field is only
added to functions / aggregates).

Please send a new version of the patch that changes the above
mentioned item, the patch also needs rebasing (off by a couple of
lines).



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: Oid registry
Следующее
От: Peter Eisentraut
Дата:
Сообщение: Re: _FORTIFY_SOURCE by default?