Re: [PATCH] introduce XLogLockBlockRangeForCleanup()

Поиск

Список

Период

Сортировка

От	Amit Khandekar
Тема	Re: [PATCH] introduce XLogLockBlockRangeForCleanup()
Дата	7 июля 2014 г. 11:32:50
Msg-id	CACoZds2nbjNUBBJ4vo0fepS+NVBAhYLfK5NZNiUa3PBr2-bmWQ@mail.gmail.com обсуждение исходный текст
Ответ на	Re: [PATCH] introduce XLogLockBlockRangeForCleanup() (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
Ответы	Re: [PATCH] introduce XLogLockBlockRangeForCleanup() (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
Список	pgsql-hackers

On 4 July 2014 19:11, Abhijit Menon-Sen <ams@2ndquadrant.com> wrote:

Updated patch attached, thanks.

Amit: what's your conclusion from the review?

Other than some minor comments as mentioned below, I don't have any more issues, it looks all good.

XLogLockBlockRangeForCleanup() function header comments has the function name spelled: XLogBlockRangeForCleanup

In GetBufferWithoutRelcache(), we can call BufferDescriptorGetBuffer(buf) rather than BufferDescriptorGetBuffer(&BufferDescriptors[buf_id]).

-- Abhijit

В списке pgsql-hackers по дате отправления:

От: Jeff Davis
Дата: 07 июля 2014 г., 11:21:05
Сообщение: Re: Request for Patch Feedback: Lag & Lead Window Functions Can Ignore Nulls

От: Abhijit Menon-Sen
Дата: 07 июля 2014 г., 11:46:19
Сообщение: Re: [PATCH] introduce XLogLockBlockRangeForCleanup()