On Fri, Sep 9, 2016 at 4:25 PM, Kevin Grittner <kgrittn@gmail.com> wrote:
> On Sun, Sep 4, 2016 at 12:42 PM, Emre Hasegeli <emre@hasegeli.com> wrote:
> These patches apply and build on top of 5c609a74 with no problems,
> but `make check` finds differences per the attached. Please
> investigate why the regression tests are failing and what the
> appropriate response is.
>> I am not much experienced in C. If you think that inline functions
>> are better suited, I can rework the patches.
>
> I suspect that they will be as fast or faster, and they eliminate
> the hazard of multiple evaluation, where a programmer might not be
> aware of the multiple evaluation or of some side-effect of an
> argument.
Emre, are you going to address the above? It would have to be Real
Soon Now.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company