On Mon, Apr 3, 2017 at 8:59 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Thomas Munro <thomas.munro@enterprisedb.com> writes:
>> Or perhaps the code to inject trigger data transition tables into SPI
>> (a near identical code block these three patches) should be somewhere
>> common so that each PLs would only need to call a function. If so,
>> where should that go?
>
> spi.c?
Until now, trigger.c didn't know about SPI, and spi.c didn't know
about triggers. The intersection was left to referencing code, like
PLs. Is there any other common code among the PLs dealing with this
intersection? If so, maybe a new triggerspi.c file (or
spitrigger.c?) would make sense. Possibly it could make sense from
a code structure PoV even for a single function, but it seems kinda
iffy for just this function. As far as I can see it comes down to
adding it to spi.c or creating a new file -- or just duplicating
these 30-some lines of code to every PL.
--
Kevin Grittner