Re: Optimze usage of immutable functions as relation

Поиск
Список
Период
Сортировка
От Aleksandr Parfenov
Тема Re: Optimze usage of immutable functions as relation
Дата
Msg-id CACdpekK1oDy7-_HnXOaREa_8HM2r-fsp8iv5e6p8aWOdGdK8Mg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Optimze usage of immutable functions as relation  (Anthony Bykov <a.bykov@postgrespro.ru>)
Ответы Re: Optimze usage of immutable functions as relation
Re: Optimze usage of immutable functions as relation
Re: Optimze usage of immutable functions as relation
Список pgsql-hackers
Hi,

Thank you for the review.
I fixed a typo and some comments. Please find new version attached.

---
Best regards,
Parfenov Aleksandr

On Fri, 19 Oct 2018 at 16:40, Anthony Bykov <a.bykov@postgrespro.ru> wrote:
The following review has been posted through the commitfest application:
make installcheck-world:  tested, failed
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            not tested

Hello,
I was trying to review your patch, but I couldn't install it:

prepjointree.c: In function ‘pull_up_simple_function’:
prepjointree.c:1793:41: error: ‘functions’ undeclared (first use in this function); did you mean ‘PGFunction’?
  Assert(!contain_vars_of_level((Node *) functions, 0));

Was it a typo?

The new status of this patch is: Waiting on Author
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: pgsql: Add TAP tests for pg_verify_checksums
Следующее
От: Apurv Shah
Дата:
Сообщение: Google Code In Mentorship